Skip to content

Evm sidechain screen#1380

Merged
benma merged 2 commits intoBitBoxSwiss:masterfrom
Tomasvrba:evm-sidechain-screen
Mar 20, 2025
Merged

Evm sidechain screen#1380
benma merged 2 commits intoBitBoxSwiss:masterfrom
Tomasvrba:evm-sidechain-screen

Conversation

@Tomasvrba
Copy link
Copy Markdown
Collaborator

add a new screen confirmation to the user verification workflow for known L2s and sidechains

@Tomasvrba Tomasvrba force-pushed the evm-sidechain-screen branch from 001edee to 5a6b43e Compare March 11, 2025 11:45
Copy link
Copy Markdown
Collaborator

@benma benma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement!

Comment thread src/rust/bitbox02-rust/src/hww/api/ethereum/sign.rs
Comment thread src/rust/bitbox02-rust/src/hww/api/ethereum/sign.rs Outdated
Comment thread src/rust/bitbox02-rust/src/hww/api/ethereum/sign.rs Outdated
@Tomasvrba Tomasvrba force-pushed the evm-sidechain-screen branch from 2364172 to 02a0c8a Compare March 13, 2025 14:23
@Tomasvrba Tomasvrba requested a review from benma March 13, 2025 14:23
@Tomasvrba Tomasvrba force-pushed the evm-sidechain-screen branch 2 times, most recently from 7d6a797 to 7fa1e99 Compare March 13, 2025 14:30
Comment thread src/rust/bitbox02-rust/src/hww/api/ethereum/sign.rs Outdated
Comment thread src/rust/bitbox02-rust/src/hww/api/ethereum/sign.rs Outdated
Comment thread CHANGELOG.md Outdated
@Tomasvrba Tomasvrba force-pushed the evm-sidechain-screen branch 2 times, most recently from bbee180 to 5a2e3d4 Compare March 16, 2025 15:44
@Tomasvrba Tomasvrba requested a review from benma March 16, 2025 15:44
@Tomasvrba Tomasvrba force-pushed the evm-sidechain-screen branch 3 times, most recently from a072808 to faf3199 Compare March 20, 2025 11:34
Copy link
Copy Markdown
Collaborator

@benma benma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, thank you!

@Tomasvrba Tomasvrba force-pushed the evm-sidechain-screen branch from faf3199 to f6f5274 Compare March 20, 2025 11:41
@benma benma merged commit 90a72cc into BitBoxSwiss:master Mar 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants